[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2023-06-18 Thread via GitHub
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1596096298 @guozhangwang Please review and merge. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2023-02-02 Thread via GitHub
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1414078362 Ack. Let me update the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-12-19 Thread GitBox
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1357467108 Hi @cadonna, Just a reminder for the review. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-11-09 Thread GitBox
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1308922420 Hi @divijvaidya Please review once. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-10-14 Thread GitBox
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1278967518 Ping for the PR review @C0urante Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-10-14 Thread GitBox
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1278966484 Thanks @guozhangwang for the review. I have updated the PR, please have a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-10-14 Thread GitBox
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1278946808 Failing tests seem unrelated [ kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsToZonedDateTime, kafka.admin.MetadataQuorumCommandTest.testDescribeQuorumReplica

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-10-14 Thread GitBox
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1278750513 Not sure why these checks failed. These failures are not looking relevant. Please someone help. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-10-13 Thread GitBox
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1278517048 I am not sure why one test case failed : https://github.com/apache/kafka/pull/12739/checks?check_run_id=8869541214 . I have not done any change in any other test file. -- This is