[GitHub] [kafka] showuon commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

2022-05-03 Thread GitBox
showuon commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r86375 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeConnectProtocol.java: ## @@ -148,18 +148,18 @@ public class

[GitHub] [kafka] showuon commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

2022-05-03 Thread GitBox
showuon commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r863399174 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeConnectProtocol.java: ## @@ -148,18 +148,18 @@ public class

[GitHub] [kafka] showuon commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

2022-05-02 Thread GitBox
showuon commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r863325064 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -336,13 +332,16 @@ ClusterAssignment

[GitHub] [kafka] showuon commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

2022-04-29 Thread GitBox
showuon commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r861753163 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeConnectProtocol.java: ## @@ -230,15 +230,16 @@ public static

[GitHub] [kafka] showuon commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

2022-04-29 Thread GitBox
showuon commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r861528608 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeConnectProtocol.java: ## @@ -230,15 +230,16 @@ public static

[GitHub] [kafka] showuon commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

2022-04-28 Thread GitBox
showuon commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r860546268 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -298,20 +329,21 @@ protected Map

[GitHub] [kafka] showuon commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

2022-04-27 Thread GitBox
showuon commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r860454746 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java: ## @@ -1142,107 +982,65 @@ private void

[GitHub] [kafka] showuon commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

2022-04-25 Thread GitBox
showuon commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r857284813 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java: ## @@ -1375,24 +1171,6 @@ private void

[GitHub] [kafka] showuon commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

2022-04-24 Thread GitBox
showuon commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r857235521 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java: ## @@ -1142,107 +982,65 @@ private void