showuon commented on code in PR #12501: URL: https://github.com/apache/kafka/pull/12501#discussion_r951112014
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -534,6 +537,9 @@ object KafkaConfig { val TransactionsAbortTimedOutTransactionCleanupIntervalMsProp = "transaction.abort.timed.out.transaction.cleanup.interval.ms" val TransactionsRemoveExpiredTransactionalIdCleanupIntervalMsProp = "transaction.remove.expired.transaction.cleanup.interval.ms" + val ProducerIdExpirationMsProp = "producer.id.expiration.ms" + val ProducerIdExpirationCheckIntervalMsProp = "producer.id.expiration.check.ms" Review Comment: nit: `producer.id.expiration.check.ms` -> `producer.id.expiration.check.interval.ms` (add `interval` to make it clear and consistency) ########## core/src/test/scala/other/kafka/StressTestLog.scala: ########## @@ -50,7 +50,7 @@ object StressTestLog { time = time, maxTransactionTimeoutMs = 5 * 60 * 1000, maxProducerIdExpirationMs = 60 * 60 * 1000, - producerIdExpirationCheckIntervalMs = LogManager.ProducerIdExpirationCheckIntervalMs, + producerIdExpirationCheckIntervalMs = 10 * 60 * 1000, Review Comment: nit: since we've defined default value in KafkaConfigs, I think we can re-use it. That is: ``` producerIdExpirationCheckIntervalMs = kafka.server.Defaults.ProducerIdExpirationCheckIntervalMs, ``` Same comments apply to below hard code producerIdExpirationCheckIntervalMs values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org