[GitHub] [kafka] showuon commented on a diff in pull request #13850: KAFKA-15084: Remove lock contention from RemoteIndexCache

2023-06-21 Thread via GitHub
showuon commented on code in PR #13850: URL: https://github.com/apache/kafka/pull/13850#discussion_r1236592041 ## core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala: ## @@ -167,64 +235,76 @@ class RemoteIndexCache(maxSize: Int = 1024, remoteStorageManager: RemoteStorag

[GitHub] [kafka] showuon commented on a diff in pull request #13850: KAFKA-15084: Remove lock contention from RemoteIndexCache

2023-06-21 Thread via GitHub
showuon commented on code in PR #13850: URL: https://github.com/apache/kafka/pull/13850#discussion_r1236592041 ## core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala: ## @@ -167,64 +235,76 @@ class RemoteIndexCache(maxSize: Int = 1024, remoteStorageManager: RemoteStorag

[GitHub] [kafka] showuon commented on a diff in pull request #13850: KAFKA-15084: Remove lock contention from RemoteIndexCache

2023-06-19 Thread via GitHub
showuon commented on code in PR #13850: URL: https://github.com/apache/kafka/pull/13850#discussion_r1233980545 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -117,51 +128,60 @@ class RemoteIndexCacheTest { @Test def testCacheEntryExpiry():

[GitHub] [kafka] showuon commented on a diff in pull request #13850: KAFKA-15084: Remove lock contention from RemoteIndexCache

2023-06-19 Thread via GitHub
showuon commented on code in PR #13850: URL: https://github.com/apache/kafka/pull/13850#discussion_r1233805956 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -170,44 +190,173 @@ class RemoteIndexCacheTest { assertThrows(classOf[IllegalStateEx