[GitHub] [kafka] showuon commented on pull request #11898: KAFKA-7540: commit offset sync before close

2022-03-21 Thread GitBox
showuon commented on pull request #11898: URL: https://github.com/apache/kafka/pull/11898#issuecomment-1073644477 Failed tests are unrelated. ``` Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState Bui

[GitHub] [kafka] showuon commented on pull request #11898: KAFKA-7540: commit offset sync before close

2022-03-20 Thread GitBox
showuon commented on pull request #11898: URL: https://github.com/apache/kafka/pull/11898#issuecomment-1073505938 After re-enabling the `testConsumptionWithBrokerFailures`, it failed again. Looks like it has different root cause as this one. Keep disabling it. -- This is an automated mes

[GitHub] [kafka] showuon commented on pull request #11898: KAFKA-7540: commit offset sync before close

2022-03-20 Thread GitBox
showuon commented on pull request #11898: URL: https://github.com/apache/kafka/pull/11898#issuecomment-1073453573 Thanks @guozhangwang , I think this should also fix the `testConsumptionWithBrokerFailures`. I've removed the disabled flag and see if the test failed. For `testRollingBr

[GitHub] [kafka] showuon commented on pull request #11898: KAFKA-7540: commit offset sync before close

2022-03-15 Thread GitBox
showuon commented on pull request #11898: URL: https://github.com/apache/kafka/pull/11898#issuecomment-1068610630 @guozhangwang , please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo