[GitHub] [kafka] showuon commented on pull request #11963: KAFKA-13777: Fix FetchResponse#responseData: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-31 Thread GitBox
showuon commented on pull request #11963: URL: https://github.com/apache/kafka/pull/11963#issuecomment-1085305135 @yun-yun ,Yes, please submit PR to fix them. If you don't have time, you can submit a jira ticket and see if there are other people have time to fix them. Thanks. -- This is

[GitHub] [kafka] showuon commented on pull request #11963: KAFKA-13777: Fix FetchResponse#responseData: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-30 Thread GitBox
showuon commented on pull request #11963: URL: https://github.com/apache/kafka/pull/11963#issuecomment-1083965192 @yun-yun , thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] showuon commented on pull request #11963: KAFKA-13777: Fix FetchResponse#responseData: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-30 Thread GitBox
showuon commented on pull request #11963: URL: https://github.com/apache/kafka/pull/11963#issuecomment-1083964754 Failed tests are unrelated and also failed in trunk build. ``` Build / PowerPC / org.apache.kafka.clients.consumer.KafkaConsumerTest.testReturnRecordsDuringRebalance()

[GitHub] [kafka] showuon commented on pull request #11963: KAFKA-13777: Fix FetchResponse#responseData: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-30 Thread GitBox
showuon commented on pull request #11963: URL: https://github.com/apache/kafka/pull/11963#issuecomment-1083096005 I think it should be the infra's issue. I've triggered the jenkins tests again. Let's wait and see. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] showuon commented on pull request #11963: KAFKA-13777: Fix FetchResponse#responseData: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-30 Thread GitBox
showuon commented on pull request #11963: URL: https://github.com/apache/kafka/pull/11963#issuecomment-1082822128 @dajac , the impact I can think of, is that when the issue happened, which should be rare, some threads might get only partial fetch response (some partitions data is ignored),

[GitHub] [kafka] showuon commented on pull request #11963: KAFKA-13777: Fix FetchResponse#responseData: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-30 Thread GitBox
showuon commented on pull request #11963: URL: https://github.com/apache/kafka/pull/11963#issuecomment-1082807931 I'll wait for the jenkins build completed before merging it. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G