[GitHub] [kafka] showuon commented on pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-05-02 Thread GitBox
showuon commented on PR #12105: URL: https://github.com/apache/kafka/pull/12105#issuecomment-1115548710 > To be clear, the broker would have to be older than 2.8 for the issue to occur. The server change for KIP-679 happened in Apache Kafka 2.8. Yes, the user confirmed that their

[GitHub] [kafka] showuon commented on pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-04-28 Thread GitBox
showuon commented on PR #12105: URL: https://github.com/apache/kafka/pull/12105#issuecomment-1112827223 Thanks @dengziming ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] showuon commented on pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-04-28 Thread GitBox
showuon commented on PR #12105: URL: https://github.com/apache/kafka/pull/12105#issuecomment-942909 Thanks @dengziming . I checked the

[GitHub] [kafka] showuon commented on pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-04-28 Thread GitBox
showuon commented on PR #12105: URL: https://github.com/apache/kafka/pull/12105#issuecomment-907646 @dengziming , have a 2nd look, I found it's not right. [Here](https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L2185-L2194), we won't check the

[GitHub] [kafka] showuon commented on pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-04-28 Thread GitBox
showuon commented on PR #12105: URL: https://github.com/apache/kafka/pull/12105#issuecomment-878830 @dengziming , thanks for the quick investigation! Nice finding! Yes, once idempotent producer is enabled, the transactionManager will be created. And in Sender run loop