showuon commented on PR #12136:
URL: https://github.com/apache/kafka/pull/12136#issuecomment-1146566707
cherry-pick back to 3.2 branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
showuon commented on PR #12136:
URL: https://github.com/apache/kafka/pull/12136#issuecomment-1144475136
@junrao ,Thank you for your patient review!
Failed tests are unrelated.
```
Build / JDK 11 and Scala 2.13 /
kafka.controller.ControllerIntegrationTest.testTopicIdUpgradeAfterR
showuon commented on PR #12136:
URL: https://github.com/apache/kafka/pull/12136#issuecomment-1141052283
@junrao , thanks for the comment. I've updated the PR. The failed test:
`testCleanShutdownAfterFailedStartupDueToCorruptLogs` is indeed related. But
the test is not the correct expectatio
showuon commented on PR #12136:
URL: https://github.com/apache/kafka/pull/12136#issuecomment-1135580274
@junrao , I've updated the PR in this commit:
https://github.com/apache/kafka/pull/12136/commits/ca8cb7df7b7fbd17d95e7a34525840b5578fe520.
Please take a look again. Thanks.
--
This is
showuon commented on PR #12136:
URL: https://github.com/apache/kafka/pull/12136#issuecomment-1131379581
@junrao , thanks for your review. I've addressed your comments. Also, I
found we should handle `IOException` during writing `meta.properties` in
server.startup. Thanks.
--
This is an a
showuon commented on PR #12136:
URL: https://github.com/apache/kafka/pull/12136#issuecomment-1120580864
@junrao , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
