showuon commented on PR #12329: URL: https://github.com/apache/kafka/pull/12329#issuecomment-1162782518
@dajac , thanks for your review! (I was going to ping you, though :) I've addressed most of your comments. About adding tests in `AlterPartitionManagerTest`, I thought about it, but I can't find a good way to test int `AlterPartitionManagerTest` because the issue is happened during the interaction between `Partition` callback and `AlterPartitionManager` sendRequest callback. If I only tested the `AlterPartitionManagerTest`, it is not meaningful because it indeed removed the `unsentIsrUpdates`. Like the test: `AlterPartitionManagerTest#testUnknownServer` is testing what we expected. So, I'm going to leave it as is, unless you have other suggestion. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
