[GitHub] [kafka] showuon commented on pull request #13828: KAFKA-15066: add "remote.log.metadata.manager.listener.name" config to rlmm

2023-06-30 Thread via GitHub
showuon commented on PR #13828: URL: https://github.com/apache/kafka/pull/13828#issuecomment-1614319820 @jeqo , thanks for raising it. Yes, I forgot to pass the `bootstart.server` as `commonClientConfigs`, so that it won't be passed into the producer/consumer. Are you available to file a

[GitHub] [kafka] showuon commented on pull request #13828: KAFKA-15066: add "remote.log.metadata.manager.listener.name" config to rlmm

2023-06-16 Thread via GitHub
showuon commented on PR #13828: URL: https://github.com/apache/kafka/pull/13828#issuecomment-1594624985 Failed tests are unrelated and the failed `testReplication` also fail in trunk build. I've identified it's caused by this change: https://github.com/apache/kafka/pull/13838 . Go ahead to

[GitHub] [kafka] showuon commented on pull request #13828: KAFKA-15066: add "remote.log.metadata.manager.listener.name" config to rlmm

2023-06-15 Thread via GitHub
showuon commented on PR #13828: URL: https://github.com/apache/kafka/pull/13828#issuecomment-1594043903 Still cannot get a healthy CI build results. Try to rebase to the latest trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] showuon commented on pull request #13828: KAFKA-15066: add "remote.log.metadata.manager.listener.name" config to rlmm

2023-06-14 Thread via GitHub
showuon commented on PR #13828: URL: https://github.com/apache/kafka/pull/13828#issuecomment-1591076070 > > I think we don't have this implemented. We should pass remote.log.metadata.* into RLMM based on KIP-405. Created [KAFKA-15083](https://issues.apache.org/jira/browse/KAFKA-15083) for

[GitHub] [kafka] showuon commented on pull request #13828: KAFKA-15066: add "remote.log.metadata.manager.listener.name" config to rlmm

2023-06-13 Thread via GitHub
showuon commented on PR #13828: URL: https://github.com/apache/kafka/pull/13828#issuecomment-1588961245 @divijvaidya @satishd , PR updated. Thanks. > 1. We probably want to update the KIP-405 here:

[GitHub] [kafka] showuon commented on pull request #13828: KAFKA-15066: add "remote.log.metadata.manager.listener.name" config to rlmm

2023-06-12 Thread via GitHub
showuon commented on PR #13828: URL: https://github.com/apache/kafka/pull/13828#issuecomment-1586936366 > One last question Luke, should a unit test have failed when cluster.id property was missing in first revision? It probably hints towards a gap in testing. Can we add that? (or it's ok