[GitHub] [kafka] showuon commented on pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

2023-08-04 Thread via GitHub
showuon commented on PR #14133: URL: https://github.com/apache/kafka/pull/14133#issuecomment-1666390423 Failed tests are unrelated: ``` Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindR

[GitHub] [kafka] showuon commented on pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

2023-08-01 Thread via GitHub
showuon commented on PR #14133: URL: https://github.com/apache/kafka/pull/14133#issuecomment-1660201278 @divijvaidya @kamalcph , thanks for the comments. PR updated. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] showuon commented on pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

2023-08-01 Thread via GitHub
showuon commented on PR #14133: URL: https://github.com/apache/kafka/pull/14133#issuecomment-1659925965 @divijvaidya , PR updated. Please take a look when available. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] showuon commented on pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

2023-07-31 Thread via GitHub
showuon commented on PR #14133: URL: https://github.com/apache/kafka/pull/14133#issuecomment-1658003702 @kamalcph @divijvaidya , call for review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t