showuon commented on pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#issuecomment-690856399
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
showuon commented on pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#issuecomment-690856399
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
showuon commented on pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#issuecomment-691365862
@junrao , No, the failing tests are not related to my change.
**tests/Build/JDK 11**: PASS
**tests/Build/JDK 15**:
DynamicConnectionQuotaTest.testDynamicListenerConnectio
showuon commented on pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#issuecomment-690856399
@junrao , thanks for the good comments. I've updated in this commit:
https://github.com/apache/kafka/pull/9178/commits/c7f436292209f1778f9455421f67fd81eea81f21.
Thanks.
showuon commented on pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#issuecomment-690200951
@junrao , thanks for your comments. I've updated in this commit:
https://github.com/apache/kafka/pull/9178/commits/5320318eec5cdb938cafd385f45525472370d359.
Thanks.
showuon commented on pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#issuecomment-689247342
@tombentley @ijuma , could you help review this PR? Thank you.
This is an automated message from the Apache Git Se
showuon commented on pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#issuecomment-680857804
@mingaliu @hachikuji @omkreddy , could you please review this PR? Thanks.
This is an automated message from the Ap
showuon commented on pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#issuecomment-673851321
@omkreddy @hachikuji , could you review this PR? Thanks.
This is an automated message from the Apache Git Service.