[GitHub] [kafka] showuon commented on pull request #9178: KAFKA-8362: fix the old checkpoint won't be removed after alter log dir

2020-09-12 Thread GitBox
showuon commented on pull request #9178: URL: https://github.com/apache/kafka/pull/9178#issuecomment-690856399 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] showuon commented on pull request #9178: KAFKA-8362: fix the old checkpoint won't be removed after alter log dir

2020-09-12 Thread GitBox
showuon commented on pull request #9178: URL: https://github.com/apache/kafka/pull/9178#issuecomment-690856399 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] showuon commented on pull request #9178: KAFKA-8362: fix the old checkpoint won't be removed after alter log dir

2020-09-11 Thread GitBox
showuon commented on pull request #9178: URL: https://github.com/apache/kafka/pull/9178#issuecomment-691365862 @junrao , No, the failing tests are not related to my change. **tests/Build/JDK 11**: PASS **tests/Build/JDK 15**: DynamicConnectionQuotaTest.testDynamicListenerConnectio

[GitHub] [kafka] showuon commented on pull request #9178: KAFKA-8362: fix the old checkpoint won't be removed after alter log dir

2020-09-10 Thread GitBox
showuon commented on pull request #9178: URL: https://github.com/apache/kafka/pull/9178#issuecomment-690856399 @junrao , thanks for the good comments. I've updated in this commit: https://github.com/apache/kafka/pull/9178/commits/c7f436292209f1778f9455421f67fd81eea81f21. Thanks.

[GitHub] [kafka] showuon commented on pull request #9178: KAFKA-8362: fix the old checkpoint won't be removed after alter log dir

2020-09-10 Thread GitBox
showuon commented on pull request #9178: URL: https://github.com/apache/kafka/pull/9178#issuecomment-690200951 @junrao , thanks for your comments. I've updated in this commit: https://github.com/apache/kafka/pull/9178/commits/5320318eec5cdb938cafd385f45525472370d359. Thanks.

[GitHub] [kafka] showuon commented on pull request #9178: KAFKA-8362: fix the old checkpoint won't be removed after alter log dir

2020-09-08 Thread GitBox
showuon commented on pull request #9178: URL: https://github.com/apache/kafka/pull/9178#issuecomment-689247342 @tombentley @ijuma , could you help review this PR? Thank you. This is an automated message from the Apache Git Se

[GitHub] [kafka] showuon commented on pull request #9178: KAFKA-8362: fix the old checkpoint won't be removed after alter log dir

2020-08-26 Thread GitBox
showuon commented on pull request #9178: URL: https://github.com/apache/kafka/pull/9178#issuecomment-680857804 @mingaliu @hachikuji @omkreddy , could you please review this PR? Thanks. This is an automated message from the Ap

[GitHub] [kafka] showuon commented on pull request #9178: KAFKA-8362: fix the old checkpoint won't be removed after alter log dir

2020-08-13 Thread GitBox
showuon commented on pull request #9178: URL: https://github.com/apache/kafka/pull/9178#issuecomment-673851321 @omkreddy @hachikuji , could you review this PR? Thanks. This is an automated message from the Apache Git Service.