showuon edited a comment on pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#issuecomment-828440406
@ableegoldman , thanks for your great comments! If there's a best reviewer
contest, I'd definitely vote for you! :) I've replied your
`getUnassignedPartitions` comments.
showuon edited a comment on pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#issuecomment-816379867
@ableegoldman , please help review this PR. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
showuon edited a comment on pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#issuecomment-823030049
jenkins test results after my change: **(avg. 2 sec)**
```
Build / JDK 8 and Scala 2.12 /
testLargeAssignmentAndGroupWithUniformSubscription() | 1.8 sec | Passed
showuon edited a comment on pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#issuecomment-822975764
@ableegoldman (cc. @guozhangwang)
After completing the sticky general assignor improvement
(https://github.com/apache/kafka/pull/10552), I started to think... why
showuon edited a comment on pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#issuecomment-822975764
@ableegoldman (cc. @guozhangwang)
After completing the sticky general assignor improvement
(https://github.com/apache/kafka/pull/10552), I started to think... why
showuon edited a comment on pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#issuecomment-822975764
@ableegoldman (cc. @guozhangwang)
After completing the sticky general assignor improvement
(https://github.com/apache/kafka/pull/10552), I started to think... why
showuon edited a comment on pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#issuecomment-816379867
@ableegoldman , please help review this PR. The
testLargeAssignmentAndGroupWithUniformSubscription test keeps pretty much the
same performance as before, but keep the
