socutes commented on pull request #11207:
URL: https://github.com/apache/kafka/pull/11207#issuecomment-982355903
@jsancio PTAL. Can you give me some advice about this KIP? Once metrics are
added, how do you write test cases?
--
This is an automated message from the Apache Git Service.
socutes commented on pull request #11207:
URL: https://github.com/apache/kafka/pull/11207#issuecomment-954360311
> @socutes thanks for the PR. This looks good but I think we should add unit
tests in `QuorumControllerTest` for `SnapshotLagSize` and
`SnapshotSizeBytesSize`. The histogram
socutes commented on pull request #11207:
URL: https://github.com/apache/kafka/pull/11207#issuecomment-897797158
@jsancio @cmccabe please help review this pr. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
