[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-09 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r539455602 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -920,32 +954,57 @@ class AdminManager(val config: KafkaConfig, !name.isDefi

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-07 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r537945058 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -778,6 +793,10 @@ object ConfigCommand extends Config { val brokerLogger = pars

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-07 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r537945058 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -778,6 +793,10 @@ object ConfigCommand extends Config { val brokerLogger = pars

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-07 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r537937603 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -472,6 +512,134 @@ class ConfigCommandTest extends ZooKeeperTestHarness wit

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-07 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r537937180 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -472,6 +512,134 @@ class ConfigCommandTest extends ZooKeeperTestHarness wit

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536391337 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,11 +885,21 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536391337 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,11 +885,21 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536391337 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,11 +885,21 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536391337 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,11 +885,21 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536241597 ## File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala ## @@ -236,13 +310,22 @@ class ClientQuotasRequestTest extends BaseRequest

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536241597 ## File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala ## @@ -236,13 +310,22 @@ class ClientQuotasRequestTest extends BaseRequest

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536257595 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -472,6 +512,134 @@ class ConfigCommandTest extends ZooKeeperTestHarness wit

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536250843 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,11 +885,21 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536241597 ## File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala ## @@ -236,13 +310,22 @@ class ClientQuotasRequestTest extends BaseRequest

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536240414 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -920,32 +954,51 @@ class AdminManager(val config: KafkaConfig, !name.isDefi

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536238405 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -778,6 +793,10 @@ object ConfigCommand extends Config { val brokerLogger = pars

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-03 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r535397962 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -56,11 +56,12 @@ import scala.collection._ * --entity-typ

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-02 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r534496946 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -56,11 +56,12 @@ import scala.collection._ * --entity-typ

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-02 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r534494510 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -920,32 +954,49 @@ class AdminManager(val config: KafkaConfig, !name.isDefi

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-01 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r533600431 ## File path: clients/src/main/java/org/apache/kafka/common/quota/ClientQuotaEntity.java ## @@ -32,6 +32,7 @@ */ public static final String USER