[GitHub] [kafka] tinaselenge commented on a diff in pull request #14453: MINOR: Close UnifiedLog created in tests to avoid resource leak

2023-09-28 Thread via GitHub
tinaselenge commented on code in PR #14453: URL: https://github.com/apache/kafka/pull/14453#discussion_r1340283213 ## core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala: ## @@ -105,7 +105,9 @@ class DumpLogSegmentsTest { @AfterEach def tearDown(): Unit = { -

[GitHub] [kafka] tinaselenge commented on a diff in pull request #14453: MINOR: Close UnifiedLog created in tests to avoid resource leak

2023-09-27 Thread via GitHub
tinaselenge commented on code in PR #14453: URL: https://github.com/apache/kafka/pull/14453#discussion_r1338486017 ## core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala: ## @@ -71,6 +72,13 @@ class UnifiedLogTest { @AfterEach def tearDown(): Unit = { brokerTopicS

[GitHub] [kafka] tinaselenge commented on a diff in pull request #14453: MINOR: Close UnifiedLog created in tests to avoid resource leak

2023-09-27 Thread via GitHub
tinaselenge commented on code in PR #14453: URL: https://github.com/apache/kafka/pull/14453#discussion_r1338486393 ## core/src/test/scala/unit/kafka/log/LogLoaderTest.scala: ## @@ -1800,5 +1822,6 @@ class LogLoaderTest { isRemoteLogEnabled = isRemoteLogEnabled ).load

[GitHub] [kafka] tinaselenge commented on a diff in pull request #14453: MINOR: Close UnifiedLog created in tests to avoid resource leak

2023-09-27 Thread via GitHub
tinaselenge commented on code in PR #14453: URL: https://github.com/apache/kafka/pull/14453#discussion_r1338486017 ## core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala: ## @@ -71,6 +72,13 @@ class UnifiedLogTest { @AfterEach def tearDown(): Unit = { brokerTopicS