[GitHub] [kafka] tinawenqiao commented on pull request #9235: KAFKA-10449: Add some important parameter desc in connect-distributed.properties

2021-02-18 Thread GitBox
tinawenqiao commented on pull request #9235: URL: https://github.com/apache/kafka/pull/9235#issuecomment-781848357 > Thanks for the PR @tinawenqiao. > > It would be nice to also mention `rest.port` and `rest.host.name` are deprecated in their descriptions. Could you add something lik

[GitHub] [kafka] tinawenqiao commented on pull request #9235: KAFKA-10449: Add some important parameter desc in connect-distributed.properties

2021-02-19 Thread GitBox
tinawenqiao commented on pull request #9235: URL: https://github.com/apache/kafka/pull/9235#issuecomment-782045667 > @tinawenqiao It looks like you made a mistake when rebasing your branch, can you ensure the PR only contains your diff? Thanks Sorry for the mistake. A clean patch is

[GitHub] [kafka] tinawenqiao commented on pull request #9235: KAFKA-10449: Add some important parameter desc in connect-distributed.properties

2021-02-19 Thread GitBox
tinawenqiao commented on pull request #9235: URL: https://github.com/apache/kafka/pull/9235#issuecomment-782437733 > Thanks for the update, it looks much better. > > I should have been clearer, I meant to update the documentation text of these settings, not just the comments in `Work

[GitHub] [kafka] tinawenqiao commented on pull request #9235: KAFKA-10449: Add some important parameter desc in connect-distributed.properties

2021-02-23 Thread GitBox
tinawenqiao commented on pull request #9235: URL: https://github.com/apache/kafka/pull/9235#issuecomment-784798710 > > Thanks for the update, it looks much better. > > I should have been clearer, I meant to update the documentation text of these settings, not just the comments in `Worker

[GitHub] [kafka] tinawenqiao commented on pull request #9235: KAFKA-10449: Add some important parameter desc in connect-distributed.properties

2020-08-31 Thread GitBox
tinawenqiao commented on pull request #9235: URL: https://github.com/apache/kafka/pull/9235#issuecomment-684064832 In WokerConfig.java we found that REST_HOST_NAME_CONFIG(rest.host.name) and REST_PORT_CONFIG(rest.port) were deprecated. And some new configuration parameters are introduced s