[GitHub] [kafka] tombentley commented on a diff in pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-06-13 Thread GitBox
tombentley commented on code in PR #11781: URL: https://github.com/apache/kafka/pull/11781#discussion_r895874082 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1327,30 +1334,39 @@ public WorkerTask doBuild(Task task, co

[GitHub] [kafka] tombentley commented on a diff in pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-06-14 Thread GitBox
tombentley commented on code in PR #11781: URL: https://github.com/apache/kafka/pull/11781#discussion_r896737764 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1327,30 +1334,39 @@ public WorkerTask doBuild(Task task, co

[GitHub] [kafka] tombentley commented on a diff in pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-06-15 Thread GitBox
tombentley commented on code in PR #11781: URL: https://github.com/apache/kafka/pull/11781#discussion_r897812219 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1327,30 +1334,39 @@ public WorkerTask doBuild(Task task, co

[GitHub] [kafka] tombentley commented on a diff in pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-06-15 Thread GitBox
tombentley commented on code in PR #11781: URL: https://github.com/apache/kafka/pull/11781#discussion_r897830233 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java: ## @@ -274,18 +276,23 @@ public static NewTopicBuilder defineTopic(String topicName)

[GitHub] [kafka] tombentley commented on a diff in pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-06-18 Thread GitBox
tombentley commented on code in PR #11781: URL: https://github.com/apache/kafka/pull/11781#discussion_r900964836 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1425,6 +1426,256 @@ public WorkerTask doBuild(Task task, } } +