[GitHub] [kafka] tombentley commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

tombentley commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r943247605 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java: ## @@ -53,16 +72,21 @@ public static MetricsRegistry defaultRegistry() {

[GitHub] [kafka] tombentley commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

tombentley commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r943234303 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java: ## @@ -53,16 +72,21 @@ public static MetricsRegistry defaultRegistry() {

[GitHub] [kafka] tombentley commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

tombentley commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r942126401 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -98,6 +102,10 @@ public class CommonClientConfigs { public static final

[GitHub] [kafka] tombentley commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

tombentley commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r896689335 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -506,9 +511,11 @@ static KafkaAdminClient createInternal(AdminClientConfig

[GitHub] [kafka] tombentley commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

tombentley commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r892518655 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -329,6 +331,41 @@ public void testGenerateClientId() {