[GitHub] [kafka] tombentley commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-09-17 Thread GitBox
tombentley commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-694425788 @omkreddy I fixed a failing test. The rest look unrelated. Could you trigger the build again please? This is a

[GitHub] [kafka] tombentley commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-09-16 Thread GitBox
tombentley commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-693954974 @mimaison @omkreddy could one of you do the build again? This is an automated message from the Apache Git Serv

[GitHub] [kafka] tombentley commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-08-07 Thread GitBox
tombentley commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-670404348 Thinking about, it we could avoid breaking existing links by generating both old and new style ids: `whatever.config.name`. WDYT @mimaison @omkreddy? -

[GitHub] [kafka] tombentley commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-08-06 Thread GitBox
tombentley commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-669856151 @omkreddy any progress on this? This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] tombentley commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-06-18 Thread GitBox
tombentley commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-645868566 Another thought I had about improving the docs (though not for this PR) would be to have an index of links in alphabetical order at the start of each section (e.g. after "Broke

[GitHub] [kafka] tombentley commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-06-16 Thread GitBox
tombentley commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-644772529 @mimaison I know you added the per-config-key anchors. Please could you take a look at attempt to disambiguate the current situation with duplicated ids. -