tombentley commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-730988517
Thanks @chia7712 for the review!
This is an automated message from the Apache Git Service.
To respond to the
tombentley commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-730508481
@chia7712 done
This is an automated message from the Apache Git Service.
To respond to the message, please log
tombentley commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-730479015
@chia7712 I thought only committers can do that.
This is an automated message from the Apache Git Service.
To
tombentley commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-730476432
@abbccdda I think we're just waiting for your review here. Thanks.
This is an automated message from the
tombentley commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-724662509
@chia7712 For this PR I've added a test. It revealed a few places where
responses had error fields which weren't included in the count. This will
affect the metrics for those
tombentley commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-724572562
> Personally, the implementations of `errorCounts` are almost same. Maybe it
should be implemented
> by auto-generated protocol so the consistency (code style and behavior)
tombentley commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-724077206
@chia7712 is there anything more you needed on this PR?
This is an automated message from the Apache Git
tombentley commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-720421263
@chia7712 fixed, thanks.
This is an automated message from the Apache Git Service.
To respond to the message,
tombentley commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-712750465
@dongjinleekr I did a review of all the subclasses.
This is an automated message from the Apache Git Service.
tombentley commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-711043663
@abbccdda and chance you could take a look at this? Or maybe @dajac?
This is an automated message from the
tombentley commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-708340163
@abbccdda please could you take a look since you opened the JIRA? Thanks.
This is an automated message from
11 matches
Mail list logo
