tyamashi-oss opened a new pull request, #12296:
URL: https://github.com/apache/kafka/pull/12296
- Implementation:
- Add updateDesiredRatePerSec() on Throttler
- Call updateDesiredRatePerSec() of Throttler with new
log.cleaner.io.max.bytes.per.second value in reconfigure() of Log Cleaner
- I implemented the feature to be similar to [reconfigure() of
SocketServer](https://github.com/apache/kafka/blob/fa59be4e770627cd34cef85986b58ad7f606928d/core/src/main/scala/kafka/network/SocketServer.scala#L336-L357)
- Alternative implementation considered:
- re-instantiate Throttler with new log.cleaner.io.max.bytes.per.second
value in reconfigure() of Log Cleaner
- However, since many parameter specifications are required to
instantiate Throttler, I chose to be similar to SocketServer and update only
log.cleaner.io.max.bytes.per.second
- Test:
- Added unit test in case of updating DesiredRatePerSec of Throttler
- I confirmed by manual testing that log.cleaner.io.max.bytes.per.second
can be changed using bin/kafka-configs.sh:
> [2022-06-15 22:44:03,089] INFO [kafka-log-cleaner-thread-0]:
Log cleaner thread 0 cleaned log my-topic-0 (dirty section = [57585,
86901])
2,799.3 MB of log processed in 596.0 seconds (4.7 MB/sec).
Indexed 2,799.2 MB in 298.1 seconds (9.4 Mb/sec, 50.0% of total time)
Buffer utilization: 0.0%
Cleaned 2,799.3 MB in 298.0 seconds (9.4 Mb/sec, 50.0% of total time)
Start size: 2,799.3 MB (29,317 messages)
End size: 0.1 MB (1 messages)
100.0% size reduction (100.0% fewer messages)
(kafka.log.LogCleaner)`
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
