urbandan commented on code in PR #13163:
URL: https://github.com/apache/kafka/pull/13163#discussion_r1091581987
##########
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##########
@@ -246,13 +246,22 @@ public Map<String, Object> originals(Map<String, Object>
configOverrides) {
*/
public Map<String, String> originalsStrings() {
Map<String, String> copy = new RecordingMap<>();
+ copyAsStrings(originals, copy);
+ return copy;
+ }
+
+ /**
+ * Ensures that all values of a map are strings, and copies them to
another map.
+ * @param originals The map to validate.
+ * @param copy The target to copy to.
+ */
+ protected static void copyAsStrings(Map<String, ?> originals, Map<String,
String> copy) {
Review Comment:
Originally, I had this inlined in the MMConfig ctor, but didn't want to
duplicate code - anyway, I'll inline it again, that's safer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
