[GitHub] [kafka] vamossagar12 commented on pull request #12512: KAFKA-14138: Wrapping all non-fatal exceptions in KafkaException and throwing all fata exceptions directly for producer.send()

vamossagar12 commented on PR #12512: URL: https://github.com/apache/kafka/pull/12512#issuecomment-1232887757 @guozhangwang let me know when the KIP changes are done and this could be re-worked upon.. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] vamossagar12 commented on pull request #12512: KAFKA-14138: Wrapping all non-fatal exceptions in KafkaException and throwing all fata exceptions directly for producer.send()

vamossagar12 commented on PR #12512: URL: https://github.com/apache/kafka/pull/12512#issuecomment-1220313754 hello @guozhangwang Thanks for the note. I noticed that you had made some changes to the KIP. This PR, I kept the changes focussed on send method but the KIP covers all methods. Sure

[GitHub] [kafka] vamossagar12 commented on pull request #12512: KAFKA-14138: Wrapping all non-fatal exceptions in KafkaException and throwing all fata exceptions directly for producer.send()

vamossagar12 commented on PR #12512: URL: https://github.com/apache/kafka/pull/12512#issuecomment-1217053167 Looks like there are some checkstyle failures. Would fix them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] vamossagar12 commented on pull request #12512: KAFKA-14138: Wrapping all non-fatal exceptions in KafkaException and throwing all fata exceptions directly for producer.send()

vamossagar12 commented on PR #12512: URL: https://github.com/apache/kafka/pull/12512#issuecomment-1214145903 @guozhangwang , I made some changes based on what I understood of the KIP and whatever we discussed. Plz review whenever you get the chance. Thanks! -- This is an automated message