vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1441516170
Tests have passed for one of the builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1441214746
Thanks Michael. I added a happy path testcase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1437369614
Thanks @mimaison . I addressed the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1433009209
Tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1432614316
@fvaleri , I fixed the above error. Some of the containers had died because
of which the error occurred. I have a clean run of the system test now:
```
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1427752677
Thanks @fvaleri for pointing me to the fix you made for JMXTool issue. I
made the changes to also look into version when choosing the EndToEndLatency
class.
I did point out
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1426985065
@fvaleri , @mimaison here's a sample run from my local setup :
```
(ducktape) sarao@C02GG1KCML7H kafka %
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-141003
@mimaison , I updated the system test to point to the new class. That one
place seemed to be the only one relevant in this case.
--
This is an automated message from the Apache
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1408469183
> I simply meant that it looks like some changes in the system tests are
required too.
Got it. Thanks for the confirmation.
--
This is an automated message from the Apache
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1407268172
> EndToEndLatencyService
Thanks @mimaison . Actually I lack some context here. The class,
`TestEndToEndLatency` was renamed to `EndToEndLatency` with this very old PR:
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1405382219
> Sorry for the delay. Thanks for the PR, I left a few minor suggestions.
No problem! I addressed the comments. Thanks for the review.
--
This is an automated message from
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1404639472
hi @mimaison would you plz review this PR whenever you get the chance? It's
already approved by @fvaleri . Thanks
--
This is an automated message from the Apache Git Service.
To
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1387172335
> Builds on 8 and 17 are ok. Test failure on 11 is unrelated and it works
fine on my machine.
>
> Thanks.
Thanks @fvaleri . @mimaison would you be able to take a look
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1383408137
@fvaleri , thanks. I made the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1383104841
@fvaleri , i removed the code changes related to argparse4j. That way the
interface of the tool is exactly similar to what it was previously. Thanks
--
This is an automated
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1382883307
https://github.com/apache/kafka/pull/13095#discussion_r1069689088
I looked at other classes in tool and saw arg4jparse being used in them and
assumed that this is the
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1381703690
Looks like there are some more checkstyle failures. Will fix them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1381690612
hi @mimaison , I added a few basic unit tests and updated the system test
needs (end_to_end_latency.py). I haven't set it up locally but I am hoping
those should run from here to
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1375924994
Actually i pinged too soon :) Before getting it reviewed, I would test on my
local and also add a couple of tests. Thanks.
--
This is an automated message from the Apache Git
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1375755934
@ijuma , I made the changes, but I couldn't find any tests associated with
the scala class. Wanted to know how can I test this .
--
This is an automated message from the Apache
20 matches
Mail list logo
