vamossagar12 commented on PR #13453:
URL: https://github.com/apache/kafka/pull/13453#issuecomment-159051
@enzo-cappa , thanks.. yeah waiting for a round of review on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
vamossagar12 commented on PR #13453:
URL: https://github.com/apache/kafka/pull/13453#issuecomment-1546645439
The test failures now aren't related to Connect(only one related to MM but
that seems to be flaky and have notified Greg about it). @C0urante , when you
have some bandwidth, would yo
vamossagar12 commented on PR #13453:
URL: https://github.com/apache/kafka/pull/13453#issuecomment-1532463904
There are some tests for which i am not sure if they are related to this
change like `testGetActiveTopics –
org.apache.kafka.connect.integration.ConnectorTopicsIntegrationTest`. Will
vamossagar12 commented on PR #13453:
URL: https://github.com/apache/kafka/pull/13453#issuecomment-1506813946
@C0urante , yeah I did some local testing on this. I created a connector
running on a connect cluster and then brought it down and brought up a new one.
And I can see that the task s
vamossagar12 commented on PR #13453:
URL: https://github.com/apache/kafka/pull/13453#issuecomment-1503125343
Thanks for taking a look @C0urante . I had seen the warnings based on the
Java docs and I do agree that the approach taken here is broad. IIUC, [this
bit](https://github.com/apache/k
vamossagar12 commented on PR #13453:
URL: https://github.com/apache/kafka/pull/13453#issuecomment-1495428181
Failed tests seem unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
vamossagar12 commented on PR #13453:
URL: https://github.com/apache/kafka/pull/13453#issuecomment-1493589893
Thanks @yashmayya , I have responded to your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
vamossagar12 commented on PR #13453:
URL: https://github.com/apache/kafka/pull/13453#issuecomment-1483978300
@yashmayya , @gharris1727 , @C0urante Plz review whenever you get the
chance. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
