vamossagar12 commented on pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#issuecomment-773181642
Thanks @guozhangwang !
@cadonna I have added the doc here in this PR:
https://github.com/apache/kafka/pull/10051.
I will create a separate. ticket for the missing test c
vamossagar12 commented on pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#issuecomment-773181642
Thanks @guozhangwang !
@cadonna I have added the doc here in this PR:
https://github.com/apache/kafka/pull/10051.
I will create a separate. ticket for the missing test c
vamossagar12 commented on pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#issuecomment-763574872
@cadonna , done.
This is an automated message from the Apache Git Service.
To respond to the message, please
vamossagar12 commented on pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#issuecomment-759434674
@cadonna , made further changes. Plz review whenever you get a chance to do
so!
This is an automated message
vamossagar12 commented on pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#issuecomment-743088282
hey @cadonna did you get a chance to look at the latest set of changes?
This is an automated message from the
vamossagar12 commented on pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#issuecomment-736542110
Thanks @cadonna , I have resolved all comments. Plz review again if things
look ok now..
This is an automate
vamossagar12 commented on pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#issuecomment-727588493
hi @cadonna , wanted to know did you get a chance to look at my comment on
the failing test case and the changes in general?
vamossagar12 commented on pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#issuecomment-724420818
@cadonna , The failing tests here
https://github.com/apache/kafka/pull/9508/checks?check_run_id=1376108664 don't
seem to be related to this PR. Would it be possible to retest
vamossagar12 commented on pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#issuecomment-724142512
> @vamossagar12, Thank you for the PR!
>
> Here my feedback!
@cadonna thanks i made the requeiste changes barring 1.
--
