[GitHub] [kafka] vcrfxia commented on a diff in pull request #13142: KAFKA-14491: [2/N] Refactor RocksDB store open iterator management

2023-01-24 Thread via GitHub
vcrfxia commented on code in PR #13142: URL: https://github.com/apache/kafka/pull/13142#discussion_r1085933946 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java: ## @@ -351,13 +360,23 @@ public QueryResult query( @Override public ,

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13142: KAFKA-14491: [2/N] Refactor RocksDB store open iterator management

2023-01-24 Thread via GitHub
vcrfxia commented on code in PR #13142: URL: https://github.com/apache/kafka/pull/13142#discussion_r1085935187 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java: ## @@ -383,7 +383,9 @@ public KeyValue makeNext() {