vpapavas commented on pull request #11676: URL: https://github.com/apache/kafka/pull/11676#issuecomment-1018340913
Hey @patrickstuedi ! Great job! There seems to be one main comment: We had discussed that only the leaf stores (RocksDB*) would be the ones that checkpoint, no other stores whether InMemory (doesn't make sense to checkpoint since it is cleared after shutdown) or wrapping stores (since the position is the same) should checkpoint . When restoring, the leaves again will be the ones that get the position and propagate it to all the stores that are wrapping them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
