[GitHub] [kafka] vvcephei commented on a change in pull request #9221: KAFKA-10436: Implement KIP-478 Topology changes

2020-09-09 Thread GitBox
vvcephei commented on a change in pull request #9221: URL: https://github.com/apache/kafka/pull/9221#discussion_r485742765 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StatefulProcessorNode.java ## @@ -99,5 +99,14 @@ public void

[GitHub] [kafka] vvcephei commented on a change in pull request #9221: KAFKA-10436: Implement KIP-478 Topology changes

2020-09-09 Thread GitBox
vvcephei commented on a change in pull request #9221: URL: https://github.com/apache/kafka/pull/9221#discussion_r485735152 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/ProcessorParameters.java ## @@ -26,22 +30,57 @@ * Used by the Join

[GitHub] [kafka] vvcephei commented on a change in pull request #9221: KAFKA-10436: Implement KIP-478 Topology changes

2020-09-09 Thread GitBox
vvcephei commented on a change in pull request #9221: URL: https://github.com/apache/kafka/pull/9221#discussion_r485732127 ## File path: streams/src/main/java/org/apache/kafka/streams/Topology.java ## @@ -772,6 +806,94 @@ public synchronized Topology addStateStore(final

[GitHub] [kafka] vvcephei commented on a change in pull request #9221: KAFKA-10436: Implement KIP-478 Topology changes

2020-08-25 Thread GitBox
vvcephei commented on a change in pull request #9221: URL: https://github.com/apache/kafka/pull/9221#discussion_r476953793 ## File path: streams/examples/src/test/java/org/apache/kafka/streams/examples/docs/DeveloperGuideTesting.java ## @@ -145,24 +145,24 @@ public void