[GitHub] [kafka] vvcephei commented on pull request #11003: KAFKA-12360: Document new time semantics

2021-07-08 Thread GitBox
vvcephei commented on pull request #11003: URL: https://github.com/apache/kafka/pull/11003#issuecomment-876725691 Here are the rendered docs (just the sections I changed): ![task-idling-1](https://user-images.githubusercontent.com/832787/124986451-3a24a000-e001-11eb-9547-3241a177366a.png

[GitHub] [kafka] vvcephei commented on pull request #11003: KAFKA-12360: Document new time semantics

2021-07-08 Thread GitBox
vvcephei commented on pull request #11003: URL: https://github.com/apache/kafka/pull/11003#issuecomment-876730215 Note that I'll need to cherry-pick this PR to AK 3.0 once it's merged (cc @kkonstantine ) -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kafka] vvcephei commented on pull request #11003: KAFKA-12360: Document new time semantics

2021-07-08 Thread GitBox
vvcephei commented on pull request #11003: URL: https://github.com/apache/kafka/pull/11003#issuecomment-876743838 Thanks for the review, @JimGalasyn ! I've just reworded the main documentation section in response to your feedback. I also included a few other improvements I noticed on the s

[GitHub] [kafka] vvcephei commented on pull request #11003: KAFKA-12360: Document new time semantics

2021-07-12 Thread GitBox
vvcephei commented on pull request #11003: URL: https://github.com/apache/kafka/pull/11003#issuecomment-878599816 Thanks, @JimGalasyn , @showuon , and @abbccdda ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] vvcephei commented on pull request #11003: KAFKA-12360: Document new time semantics

2021-07-12 Thread GitBox
vvcephei commented on pull request #11003: URL: https://github.com/apache/kafka/pull/11003#issuecomment-878602756 Merged and cherry-picked to 3.0 (cc @kkonstantine ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the