[GitHub] [kafka] wcarlson5 commented on a change in pull request #10211: KAFKA-12347: updating TaskMetadata

2021-03-04 Thread GitBox
wcarlson5 commented on a change in pull request #10211: URL: https://github.com/apache/kafka/pull/10211#discussion_r587907372 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -1136,6 +1139,33 @@ public boolean commitNeeded(

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10211: KAFKA-12347: updating TaskMetadata

2021-03-04 Thread GitBox
wcarlson5 commented on a change in pull request #10211: URL: https://github.com/apache/kafka/pull/10211#discussion_r587874211 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java ## @@ -3112,6 +3122,26 @@ void setChangelogOffset

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10211: KAFKA-12347: updating TaskMetadata

2021-03-04 Thread GitBox
wcarlson5 commented on a change in pull request #10211: URL: https://github.com/apache/kafka/pull/10211#discussion_r587869809 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -266,13 +272,13 @@ public void suspend() {

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10211: KAFKA-12347: updating TaskMetadata

2021-03-03 Thread GitBox
wcarlson5 commented on a change in pull request #10211: URL: https://github.com/apache/kafka/pull/10211#discussion_r586728619 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -282,6 +284,21 @@ public boolean commitNeeded()

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10211: KAFKA-12347: updating TaskMetadata

2021-03-03 Thread GitBox
wcarlson5 commented on a change in pull request #10211: URL: https://github.com/apache/kafka/pull/10211#discussion_r586622218 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -282,6 +284,21 @@ public boolean commitNeeded()