[GitHub] [kafka] wenbingshen commented on pull request #10383: MINOR: Query topic describe and sort output by topic name when using adminClient

2021-06-14 Thread GitBox
wenbingshen commented on pull request #10383: URL: https://github.com/apache/kafka/pull/10383#issuecomment-859699508 @chia7712 This pr has been in the past for a long time, can you help integrate it into the trunk? Sort the topic query results by topicName, which is convenient for users to

[GitHub] [kafka] wenbingshen commented on pull request #10383: MINOR: Query topic describe and sort output by topic name when using adminClient

2021-03-25 Thread GitBox
wenbingshen commented on pull request #10383: URL: https://github.com/apache/kafka/pull/10383#issuecomment-807936687 @dajac Can you take the time to look at this pr again, if you are satisfied, can you help approved it? Thanks. :) -- This is an automated message from the Apache Git Servi

[GitHub] [kafka] wenbingshen commented on pull request #10383: MINOR: Query topic describe and sort output by topic name when using adminClient

2021-03-23 Thread GitBox
wenbingshen commented on pull request #10383: URL: https://github.com/apache/kafka/pull/10383#issuecomment-805499083 Since topic describe prints are ordered in accordance with topic name, I now detect all TopicCommandWithAdminClientTest test cases and fix possible problems. -- This is an

[GitHub] [kafka] wenbingshen commented on pull request #10383: MINOR: Query topic describe and sort output by topic name when using adminClient

2021-03-23 Thread GitBox
wenbingshen commented on pull request #10383: URL: https://github.com/apache/kafka/pull/10383#issuecomment-805460470 > Should we add a unit or integration test for this? Many thanks for your comments. I added a unit test that verifies the sequential output, please review it again. :)

[GitHub] [kafka] wenbingshen commented on pull request #10383: MINOR: Query topic describe and sort output by topic name when using adminClient

2021-03-23 Thread GitBox
wenbingshen commented on pull request #10383: URL: https://github.com/apache/kafka/pull/10383#issuecomment-805459914 > @wenbingshen thanks for this patch. LGTM Many thanks for your review. I submitted the latest code, please review it again :) -- This is an automated message from

[GitHub] [kafka] wenbingshen commented on pull request #10383: MINOR: Query topic describe and sort output by topic name when using adminClient

2021-03-23 Thread GitBox
wenbingshen commented on pull request #10383: URL: https://github.com/apache/kafka/pull/10383#issuecomment-805001602 ping @chia7712 @dajac Can you see see this minor pr?Thanks. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH