[GitHub] [kafka] yashmayya commented on a diff in pull request #12450: KAFKA-13809: Propagate full connector configuration to tasks in FileStream connectors

2022-08-09 Thread GitBox
yashmayya commented on code in PR #12450: URL: https://github.com/apache/kafka/pull/12450#discussion_r941408595 ## docs/connect.html: ## @@ -440,19 +443,17 @@ Connector @Override public List> taskConfigs(int maxTasks) { +// This method is where co

[GitHub] [kafka] yashmayya commented on a diff in pull request #12450: KAFKA-13809: Propagate full connector configuration to tasks in FileStream connectors

2022-08-08 Thread GitBox
yashmayya commented on code in PR #12450: URL: https://github.com/apache/kafka/pull/12450#discussion_r940880586 ## connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSinkConnectorTest.java: ## @@ -74,16 +73,25 @@ public void testSinkTasks() { @Test pu

[GitHub] [kafka] yashmayya commented on a diff in pull request #12450: KAFKA-13809: Propagate full connector configuration to tasks in FileStream connectors

2022-08-04 Thread GitBox
yashmayya commented on code in PR #12450: URL: https://github.com/apache/kafka/pull/12450#discussion_r938025993 ## docs/connect.html: ## @@ -423,9 +422,7 @@ Connector @Override public void start(Map props) { -// The complete version includes error han

[GitHub] [kafka] yashmayya commented on a diff in pull request #12450: KAFKA-13809: Propagate full connector configuration to tasks in FileStream connectors

2022-08-04 Thread GitBox
yashmayya commented on code in PR #12450: URL: https://github.com/apache/kafka/pull/12450#discussion_r938000827 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -16,40 +16,35 @@ */ package org.apache.kafka.connect.file; -impo

[GitHub] [kafka] yashmayya commented on a diff in pull request #12450: KAFKA-13809: Propagate full connector configuration to tasks in FileStream connectors

2022-07-31 Thread GitBox
yashmayya commented on code in PR #12450: URL: https://github.com/apache/kafka/pull/12450#discussion_r933937606 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -16,40 +16,35 @@ */ package org.apache.kafka.connect.file; -impo