yashmayya commented on code in PR #13120:
URL: https://github.com/apache/kafka/pull/13120#discussion_r1092188566
##########
connect/api/src/main/java/org/apache/kafka/connect/connector/policy/ConnectorClientConfigOverridePolicy.java:
##########
@@ -23,25 +23,25 @@
import java.util.List;
/**
- * <p>An interface for enforcing a policy on overriding of client configs via
the connector configs.
- *
- * <p>Common use cases are ability to provide principal per connector,
<code>sasl.jaas.config</code>
+ * An interface for enforcing a policy on overriding of Kafka client configs
via the connector configs.
+ * <p>
+ * Common use cases are ability to provide principal per connector,
<code>sasl.jaas.config</code>
* and/or enforcing that the producer/consumer configurations for
optimizations are within acceptable ranges.
*/
public interface ConnectorClientConfigOverridePolicy extends Configurable,
AutoCloseable {
/**
- * Worker will invoke this while constructing the producer for the
SourceConnectors, DLQ for SinkConnectors and the consumer for the
- * SinkConnectors to validate if all of the overridden client
configurations are allowed per the
- * policy implementation. This would also be invoked during the validation
of connector configs via the Rest API.
- *
+ * Workers will invoke this while constructing producer for
SourceConnectors, DLQs for SinkConnectors and
+ * consumers for SinkConnectors to validate if all of the overridden
client configurations are allowed per the
Review Comment:
Makes sense
##########
connect/api/src/main/java/org/apache/kafka/connect/connector/policy/ConnectorClientConfigRequest.java:
##########
@@ -44,25 +44,25 @@ public ConnectorClientConfigRequest(
}
/**
- * Provides Config with prefix {@code producer.override.} for {@link
ConnectorType#SOURCE}.
- * Provides Config with prefix {@code consumer.override.} for {@link
ConnectorType#SINK}.
- * Provides Config with prefix {@code producer.override.} for {@link
ConnectorType#SINK} for DLQ.
- * Provides Config with prefix {@code admin.override.} for {@link
ConnectorType#SINK} for DLQ.
+ * <p>Provides Config with prefix "{@code producer.override.}" for {@link
ConnectorType#SOURCE}.
+ * <p>Provides Config with prefix "{@code consumer.override.}" for {@link
ConnectorType#SINK}.
+ * <p>Provides Config with prefix "{@code producer.override.}" for {@link
ConnectorType#SINK} for DLQ.
+ * <p>Provides Config with prefix "{@code admin.override.}" for {@link
ConnectorType#SINK} for DLQ.
Review Comment:
Thanks, that's a great call out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
