[GitHub] [kafka] yashmayya commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

2023-07-11 Thread via GitHub
yashmayya commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1259168414 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,8 +284,51 @@ public Future set(Map values, Callback ca

[GitHub] [kafka] yashmayya commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

2023-07-10 Thread via GitHub
yashmayya commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1259168414 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,8 +284,51 @@ public Future set(Map values, Callback ca

[GitHub] [kafka] yashmayya commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

2023-07-10 Thread via GitHub
yashmayya commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1259161121 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,8 +284,51 @@ public Future set(Map values, Callback ca

[GitHub] [kafka] yashmayya commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

2023-07-10 Thread via GitHub
yashmayya commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1259160336 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,8 +284,51 @@ public Future set(Map values, Callback ca

[GitHub] [kafka] yashmayya commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

2023-07-10 Thread via GitHub
yashmayya commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1258189389 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,8 +284,51 @@ public Future set(Map values, Callback ca

[GitHub] [kafka] yashmayya commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

2023-07-07 Thread via GitHub
yashmayya commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1255456909 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,8 +284,60 @@ public Future set(Map values, Callback ca

[GitHub] [kafka] yashmayya commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

2023-07-07 Thread via GitHub
yashmayya commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1255451696 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,10 +284,61 @@ public Future set(Map values, Callback c

[GitHub] [kafka] yashmayya commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

2023-06-23 Thread via GitHub
yashmayya commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1239720643 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java: ## @@ -192,6 +209,236 @@ public void testCancelAfterAwaitFlush() throw

[GitHub] [kafka] yashmayya commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

2023-06-19 Thread via GitHub
yashmayya commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1233861544 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -140,6 +142,9 @@ public static ConnectorOffsetBackingStore

[GitHub] [kafka] yashmayya commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

2023-06-06 Thread via GitHub
yashmayya commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1219648522 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java: ## @@ -192,6 +197,220 @@ public void testCancelAfterAwaitFlush() throw

[GitHub] [kafka] yashmayya commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

2023-06-06 Thread via GitHub
yashmayya commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1219596953 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,10 +280,33 @@ public Future set(Map values, Callback c

[GitHub] [kafka] yashmayya commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

2023-06-02 Thread via GitHub
yashmayya commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1214236252 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,30 +280,47 @@ public Future set(Map values, Callback c