[GitHub] [kafka] yashmayya commented on a diff in pull request #13945: KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector

2023-07-18 Thread via GitHub
yashmayya commented on code in PR #13945: URL: https://github.com/apache/kafka/pull/13945#discussion_r1266275006 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -101,4 +105,49 @@ public ExactlyOnceSupport exactlyOnceSupport(Map

[GitHub] [kafka] yashmayya commented on a diff in pull request #13945: KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector

2023-07-18 Thread via GitHub
yashmayya commented on code in PR #13945: URL: https://github.com/apache/kafka/pull/13945#discussion_r1266275006 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -101,4 +105,49 @@ public ExactlyOnceSupport exactlyOnceSupport(Map

[GitHub] [kafka] yashmayya commented on a diff in pull request #13945: KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector

2023-07-12 Thread via GitHub
yashmayya commented on code in PR #13945: URL: https://github.com/apache/kafka/pull/13945#discussion_r1261948519 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -101,4 +105,50 @@ public ExactlyOnceSupport exactlyOnceSupport(Map

[GitHub] [kafka] yashmayya commented on a diff in pull request #13945: KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector

2023-07-12 Thread via GitHub
yashmayya commented on code in PR #13945: URL: https://github.com/apache/kafka/pull/13945#discussion_r1261948519 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -101,4 +105,50 @@ public ExactlyOnceSupport exactlyOnceSupport(Map

[GitHub] [kafka] yashmayya commented on a diff in pull request #13945: KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector

2023-07-12 Thread via GitHub
yashmayya commented on code in PR #13945: URL: https://github.com/apache/kafka/pull/13945#discussion_r1261515978 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -101,4 +105,50 @@ public ExactlyOnceSupport exactlyOnceSupport(Map

[GitHub] [kafka] yashmayya commented on a diff in pull request #13945: KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector

2023-07-12 Thread via GitHub
yashmayya commented on code in PR #13945: URL: https://github.com/apache/kafka/pull/13945#discussion_r1260946148 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -101,4 +105,50 @@ public ExactlyOnceSupport exactlyOnceSupport(Map

[GitHub] [kafka] yashmayya commented on a diff in pull request #13945: KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector

2023-07-11 Thread via GitHub
yashmayya commented on code in PR #13945: URL: https://github.com/apache/kafka/pull/13945#discussion_r1259827626 ## connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceConnectorTest.java: ## @@ -147,4 +152,102 @@ public void testInvalidBatchSize() {

[GitHub] [kafka] yashmayya commented on a diff in pull request #13945: KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector

2023-07-11 Thread via GitHub
yashmayya commented on code in PR #13945: URL: https://github.com/apache/kafka/pull/13945#discussion_r1259821609 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -101,4 +105,50 @@ public ExactlyOnceSupport exactlyOnceSupport(Map

[GitHub] [kafka] yashmayya commented on a diff in pull request #13945: KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector

2023-07-11 Thread via GitHub
yashmayya commented on code in PR #13945: URL: https://github.com/apache/kafka/pull/13945#discussion_r1259821859 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -101,4 +105,50 @@ public ExactlyOnceSupport exactlyOnceSupport(Map

[GitHub] [kafka] yashmayya commented on a diff in pull request #13945: KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector

2023-07-11 Thread via GitHub
yashmayya commented on code in PR #13945: URL: https://github.com/apache/kafka/pull/13945#discussion_r1259462328 ## connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceConnectorTest.java: ## @@ -147,4 +151,59 @@ public void testInvalidBatchSize() {

[GitHub] [kafka] yashmayya commented on a diff in pull request #13945: KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector

2023-07-08 Thread via GitHub
yashmayya commented on code in PR #13945: URL: https://github.com/apache/kafka/pull/13945#discussion_r1257110479 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -101,4 +105,40 @@ public ExactlyOnceSupport exactlyOnceSupport(Map