[GitHub] [kafka] yashmayya commented on a diff in pull request #14304: KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, value, and header converter classes

2023-09-07 Thread via GitHub
yashmayya commented on code in PR #14304: URL: https://github.com/apache/kafka/pull/14304#discussion_r1318291411 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1090,6 +1090,23 @@ public interface UncheckedCloseable extends AutoCloseable { voi

[GitHub] [kafka] yashmayya commented on a diff in pull request #14304: KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, value, and header converter classes

2023-09-01 Thread via GitHub
yashmayya commented on code in PR #14304: URL: https://github.com/apache/kafka/pull/14304#discussion_r1312900639 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/InstantiableClassValidator.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] yashmayya commented on a diff in pull request #14304: KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, value, and header converter classes

2023-09-01 Thread via GitHub
yashmayya commented on code in PR #14304: URL: https://github.com/apache/kafka/pull/14304#discussion_r1312897811 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java: ## @@ -82,17 +86,29 @@ public class ConnectorConfig extends AbstractConfig {

[GitHub] [kafka] yashmayya commented on a diff in pull request #14304: KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, value, and header converter classes

2023-09-01 Thread via GitHub
yashmayya commented on code in PR #14304: URL: https://github.com/apache/kafka/pull/14304#discussion_r1312896811 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/ConcreteSubClassValidator.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] yashmayya commented on a diff in pull request #14304: KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, value, and header converter classes

2023-09-01 Thread via GitHub
yashmayya commented on code in PR #14304: URL: https://github.com/apache/kafka/pull/14304#discussion_r1312895366 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1090,6 +1090,23 @@ public interface UncheckedCloseable extends AutoCloseable { voi

[GitHub] [kafka] yashmayya commented on a diff in pull request #14304: KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, value, and header converter classes

2023-08-30 Thread via GitHub
yashmayya commented on code in PR #14304: URL: https://github.com/apache/kafka/pull/14304#discussion_r1309974448 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1090,6 +1090,23 @@ public interface UncheckedCloseable extends AutoCloseable { voi