[GitHub] [kafka] yashmayya commented on pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

2023-08-01 Thread via GitHub
yashmayya commented on PR #13530: URL: https://github.com/apache/kafka/pull/13530#issuecomment-1660303528 Hey Chris, thanks for the reviews and apologies for the late response. > Honestly, I think the biggest obstacle to preventing pause/resume for connectors that have failed to gener

[GitHub] [kafka] yashmayya commented on pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

2023-06-11 Thread via GitHub
yashmayya commented on PR #13530: URL: https://github.com/apache/kafka/pull/13530#issuecomment-1586626234 One thing to note is that all existing connector failure state transitions occur through `WorkerConnector::onFailure` which updates an internal state to `FAILED` as well as the external

[GitHub] [kafka] yashmayya commented on pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

2023-06-07 Thread via GitHub
yashmayya commented on PR #13530: URL: https://github.com/apache/kafka/pull/13530#issuecomment-1581235501 > which is oddly not showing up on the GitHub PR UI, although it does show up on my fork's branch which this PR is created from https://www.githubstatus.com/incidents/1g1gkh0qpyvs

[GitHub] [kafka] yashmayya commented on pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

2023-06-07 Thread via GitHub
yashmayya commented on PR #13530: URL: https://github.com/apache/kafka/pull/13530#issuecomment-1581192139 > Modifying the status parts of the REST API seems less like introducing further divergence and more like honestly reporting that existing divergence to users. Fair enough, I've

[GitHub] [kafka] yashmayya commented on pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

2023-06-04 Thread via GitHub
yashmayya commented on PR #13530: URL: https://github.com/apache/kafka/pull/13530#issuecomment-1576134917 > mark connectors FAILED in the REST API if we've encountered an error while interacting with them, and will not (automatically) retry that interaction I'm wondering whether intro