[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2023-06-22 Thread via GitHub
yeralin commented on PR #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-1603491428 @venkatesh010 could you please provide a code snippet? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-13 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-840856470 @ableegoldman Seems like all checks passed :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-840015831 Ok, updated the KIP with serializing nulls for different strategies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-20 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-823384191 @ableegoldman Did you have time to look at it? Let me know if you need more context on my comments. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-821515617 Replied under each review comment, waiting for response before pushing the review changes. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-13 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-819226355 I am! :) Routinely checking this PR. I totally understand, we all get busy sometimes  -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-03-26 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-808566124 Bump -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-02-13 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-778674831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-02-09 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-776422927 Any updates on this? :) This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-01-21 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-763952940 @mjsax Hey, just rebased my branch with the trunk, updated my tests to use JUnit 5. Let me know when you guys will have time to review it.

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-01-20 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-763952940 @mjsax Hey, just rebased my branch with the trunk, updated my tests to use JUnit 5. Let me know when you guys will have time to review it.

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2020-11-19 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-730815895 Hi, any updates on this? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2020-10-02 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-702774321 @mjsax Let me know when I can jump back to it :) This is an automated message from the Apache Git Service. To

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2020-09-25 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-698414958 Any updates :)? This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2020-09-24 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-698414958 Any updates :)? This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-29 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-665078937 Any updates? This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-657756747 Aan I am back!  Sorry for such a long break, was dealing with some personal stuff and work. Pushed a few commits with `null-index-list` and `negative-size`