Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

chia7712 merged PR #15850: URL: https://github.com/apache/kafka/pull/15850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

nizhikov commented on code in PR #15850: URL: https://github.com/apache/kafka/pull/15850#discussion_r1590805333 ## core/src/test/java/kafka/admin/ConfigCommandUnitTest.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

chia7712 commented on code in PR #15850: URL: https://github.com/apache/kafka/pull/15850#discussion_r1590791878 ## core/src/test/java/kafka/admin/ConfigCommandUnitTest.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

nizhikov commented on code in PR #15850: URL: https://github.com/apache/kafka/pull/15850#discussion_r1590734676 ## core/src/test/java/kafka/admin/ConfigCommandUnitTest.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

nizhikov commented on code in PR #15850: URL: https://github.com/apache/kafka/pull/15850#discussion_r1590734676 ## core/src/test/java/kafka/admin/ConfigCommandUnitTest.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

chia7712 commented on code in PR #15850: URL: https://github.com/apache/kafka/pull/15850#discussion_r1590709330 ## core/src/test/java/kafka/admin/ConfigCommandUnitTest.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

nizhikov commented on PR #15850: URL: https://github.com/apache/kafka/pull/15850#issuecomment-2095407751 CI looks OK @chia7712 Do you have any other comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

nizhikov commented on code in PR #15850: URL: https://github.com/apache/kafka/pull/15850#discussion_r1589172610 ## core/src/test/java/kafka/admin/JConfigCommandTest.java: ## @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribu

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

chia7712 commented on code in PR #15850: URL: https://github.com/apache/kafka/pull/15850#discussion_r1589072485 ## core/src/test/java/kafka/admin/JConfigCommandTest.java: ## @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribu

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

nizhikov commented on PR #15850: URL: https://github.com/apache/kafka/pull/15850#issuecomment-2092651643 CI looks OK for me. PR ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

nizhikov commented on PR #15850: URL: https://github.com/apache/kafka/pull/15850#issuecomment-2092088305 Hello @chia7712 This PR is first part of rewriting `ConfigCommandTest` in java. As you may see, test cases checks different variation of `ConfigCommand` options both - zk and k

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

nizhikov commented on PR #15850: URL: https://github.com/apache/kafka/pull/15850#issuecomment-2092075342 Parent PR is #15839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [1/N] ConfigCommandTest rewritten in java [kafka]

nizhikov opened a new pull request, #15850: URL: https://github.com/apache/kafka/pull/15850 This is third part of https://github.com/apache/kafka/pull/15417 refactoring. PR intention - split big PR in parts to simplify review. PR contains first part of ConfigCommandTest rewritten in jav