mimaison merged PR #16065:
URL: https://github.com/apache/kafka/pull/16065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
sjhajharia commented on code in PR #16065:
URL: https://github.com/apache/kafka/pull/16065#discussion_r1627281812
##
metadata/src/test/java/org/apache/kafka/image/ImageDowngradeTest.java:
##
@@ -103,7 +103,7 @@ public void testPremodernVersion() {
@Test
public void tes
mimaison commented on code in PR #16065:
URL: https://github.com/apache/kafka/pull/16065#discussion_r1627273677
##
metadata/src/test/java/org/apache/kafka/image/ImageDowngradeTest.java:
##
@@ -103,7 +103,7 @@ public void testPremodernVersion() {
@Test
public void testP
mimaison commented on code in PR #16065:
URL: https://github.com/apache/kafka/pull/16065#discussion_r1627273677
##
metadata/src/test/java/org/apache/kafka/image/ImageDowngradeTest.java:
##
@@ -103,7 +103,7 @@ public void testPremodernVersion() {
@Test
public void testP
sjhajharia commented on code in PR #16065:
URL: https://github.com/apache/kafka/pull/16065#discussion_r1626241269
##
metadata/src/test/java/org/apache/kafka/image/ImageDowngradeTest.java:
##
@@ -103,7 +103,7 @@ public void testPremodernVersion() {
@Test
public void tes
mimaison commented on code in PR #16065:
URL: https://github.com/apache/kafka/pull/16065#discussion_r1626203185
##
metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java:
##
@@ -2664,7 +2664,7 @@ public void testKRaftClusterDescriber() {
c
sjhajharia commented on code in PR #16065:
URL: https://github.com/apache/kafka/pull/16065#discussion_r1626179740
##
metadata/src/main/java/org/apache/kafka/metadata/FinalizedControllerFeatures.java:
##
@@ -66,11 +66,9 @@ public boolean equals(Object o) {
@Override
p
mimaison commented on code in PR #16065:
URL: https://github.com/apache/kafka/pull/16065#discussion_r1626008733
##
metadata/src/main/java/org/apache/kafka/metadata/FinalizedControllerFeatures.java:
##
@@ -66,11 +66,9 @@ public boolean equals(Object o) {
@Override
pub
sjhajharia commented on PR #16065:
URL: https://github.com/apache/kafka/pull/16065#issuecomment-2147441779
Thanks @mimaison for the review!
I cleaned up the extra indentation changes and resolved some additional
comments. Could you pls help review the same again!
--
This is an automate
sjhajharia commented on code in PR #16065:
URL: https://github.com/apache/kafka/pull/16065#discussion_r1625927993
##
metadata/src/main/java/org/apache/kafka/metadata/FinalizedControllerFeatures.java:
##
@@ -66,11 +66,9 @@ public boolean equals(Object o) {
@Override
p
mimaison commented on code in PR #16065:
URL: https://github.com/apache/kafka/pull/16065#discussion_r1622393809
##
metadata/src/test/java/org/apache/kafka/metadata/RecordTestUtils.java:
##
@@ -373,12 +373,12 @@ public static RegisterControllerRecord
createTestControllerRegistra
sjhajharia opened a new pull request, #16065:
URL: https://github.com/apache/kafka/pull/16065
## What
Code Cleanup in metadata Module
## Changes
Some common changes include
- Replace the Arrays.asList() with Collections.singletonList() wherever
possible
- Cleaning up s
12 matches
Mail list logo
