Re: [PR] KAFKA-16305: Avoid optimisation in handshakeUnwrap [kafka]

2024-02-28 Thread via GitHub
rajinisivaram merged PR #15434: URL: https://github.com/apache/kafka/pull/15434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.a

Re: [PR] KAFKA-16305: Avoid optimisation in handshakeUnwrap [kafka]

2024-02-28 Thread via GitHub
rajinisivaram commented on PR #15434: URL: https://github.com/apache/kafka/pull/15434#issuecomment-1968572233 Test failures not related, merging to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16305: Avoid optimisation in handshakeUnwrap [kafka]

2024-02-27 Thread via GitHub
gaurav-narula commented on code in PR #15434: URL: https://github.com/apache/kafka/pull/15434#discussion_r1504044580 ## clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java: ## @@ -1467,4 +1476,51 @@ int updateAndGet(int actualSize, boolean update) {

Re: [PR] KAFKA-16305: Avoid optimisation in handshakeUnwrap [kafka]

2024-02-27 Thread via GitHub
rajinisivaram commented on code in PR #15434: URL: https://github.com/apache/kafka/pull/15434#discussion_r1504009367 ## clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java: ## @@ -1467,4 +1476,51 @@ int updateAndGet(int actualSize, boolean update) {

Re: [PR] KAFKA-16305: Avoid optimisation in handshakeUnwrap [kafka]

2024-02-26 Thread via GitHub
gaurav-narula commented on code in PR #15434: URL: https://github.com/apache/kafka/pull/15434#discussion_r1503432226 ## clients/src/test/java/org/apache/kafka/common/security/ssl/NettySslEngineFactory.java: ## @@ -0,0 +1,159 @@ +package org.apache.kafka.common.security.ssl; + +i

Re: [PR] KAFKA-16305: Avoid optimisation in handshakeUnwrap [kafka]

2024-02-26 Thread via GitHub
ijuma commented on code in PR #15434: URL: https://github.com/apache/kafka/pull/15434#discussion_r1503149170 ## clients/src/test/java/org/apache/kafka/common/security/ssl/NettySslEngineFactory.java: ## @@ -0,0 +1,159 @@ +package org.apache.kafka.common.security.ssl; + +import io