dajac commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1827911402
Thanks for the explanation, @alok123t! I think that we could fix those
separately, if we want to. @divijvaidya Do you want to do a final review?
--
This is an automated message from the A
alok123t commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1827838896
> Hey @alok123t. Thanks for working on this. In the last build, I just
noticed that parameterized still are still reported as:
>
> ```
> Build / JDK 21 and Scala 2.13 / [5] Type
dajac commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1827493259
@alok123t Any progress on this one? I actually need it to continue my
[experiment](https://github.com/apache/kafka/pull/14743) to improve our CI.
--
This is an automated message from the
dajac commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1812491676
Hey @alok123t. Thanks for working on this. In the last build, I just noticed
that parameterized still are still reported as:
```
Build / JDK 21 and Scala 2.13 / [5] Type=ZK, MetadataVe
alok123t commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1812467554
@divijvaidya looks unrelated. Most failed tests are related to
`RestoreIntegrationTest` - likely some regression when I merged in latest
changes from trunk to trigger a new build
--
T
divijvaidya commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1812459578
We have an unusually large number of failures. @alok123t can you please
check the failures to see if they might be related to this change?
--
This is an automated message from the A
divijvaidya commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1808020892
I triggered a re-build of the CI since JDK11+Scala 2.13 was failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
alok123t commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1805185143
@divijvaidya I think it looks reasonable JUnit 4 test -
[ConsistencyVectorIntegrationTest](
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14687/5/testReport/junit/org.apa
divijvaidya commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1795080507
> @divijvaidya looks like we only need add the junit file in root modules
like `server-common` and `clients` and other should be able to import
Sweet! Please verify after the CI
alok123t commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1794910231
@divijvaidya looks like we only need add the junit file in root modules like
`server-common` and `clients` and other should be able to import
--
This is an automated message from the
divijvaidya commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1794443451
@alok123t Let me know when this is ready for review. And yes, let's just add
this proactively to all modules OR, is it possible to put it at one place and
apply for all modules (in bu
alok123t commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1792000985
Thanks for the context on JUnit4, once the build completes. Looks like
streams/connect today use this, example
[ConsistencyVectorIntegrationTest](https://ci-builds.apache.org/job/Kafka/j
alok123t commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1791997526
@divijvaidya added in modules, where `ParameterizedTest` is currently used
as part of
https://github.com/apache/kafka/pull/14687/commits/777d14d3aba7c59070916497388d82adeb19405a.
We cou
divijvaidya commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1790354592
This is a great change but note that we don't use JUnit5 for all tests.
Hence we need to ensure that this change doesn't impact Junit4 tests. Ref:
https://github.com/apache/kafka/b
alok123t opened a new pull request, #14687:
URL: https://github.com/apache/kafka/pull/14687
In many parameterized tests, the display name is broken. Example -
`testMetadataFetch` appears as `[1] true`, `[2] false`
[link](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14607/9/te
15 matches
Mail list logo
