[PR] KAFKA-10199: Handle assignment with new remove operation in state updater [kafka]

2024-05-07 Thread via GitHub
cadonna opened a new pull request, #15882: URL: https://github.com/apache/kafka/pull/15882 Uses the new remove operation of the state updater that returns a future to handle task assignment. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementa

Re: [PR] KAFKA-10199: Handle assignment with new remove operation in state updater [kafka]

2024-05-08 Thread via GitHub
lucasbru commented on code in PR #15882: URL: https://github.com/apache/kafka/pull/15882#discussion_r1593738288 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -544,69 +585,78 @@ private void handleReassignedActiveTask(final Task tas

Re: [PR] KAFKA-10199: Handle assignment with new remove operation in state updater [kafka]

2024-05-08 Thread via GitHub
cadonna commented on code in PR #15882: URL: https://github.com/apache/kafka/pull/15882#discussion_r1593835933 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -544,69 +585,78 @@ private void handleReassignedActiveTask(final Task task

Re: [PR] KAFKA-10199: Handle assignment with new remove operation in state updater [kafka]

2024-05-08 Thread via GitHub
cadonna commented on code in PR #15882: URL: https://github.com/apache/kafka/pull/15882#discussion_r1593836743 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -365,17 +365,47 @@ public void handleAssignment(final Map> activeTasks,

Re: [PR] KAFKA-10199: Handle assignment with new remove operation in state updater [kafka]

2024-05-08 Thread via GitHub
lucasbru commented on code in PR #15882: URL: https://github.com/apache/kafka/pull/15882#discussion_r1593900987 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -544,69 +585,78 @@ private void handleReassignedActiveTask(final Task tas

Re: [PR] KAFKA-10199: Handle assignment with new remove operation in state updater [kafka]

2024-05-08 Thread via GitHub
cadonna commented on code in PR #15882: URL: https://github.com/apache/kafka/pull/15882#discussion_r1593995260 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -544,69 +585,78 @@ private void handleReassignedActiveTask(final Task task

Re: [PR] KAFKA-10199: Handle assignment with new remove operation in state updater [kafka]

2024-05-13 Thread via GitHub
cadonna merged PR #15882: URL: https://github.com/apache/kafka/pull/15882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-10199: Handle assignment with new remove operation in state updater [kafka]

2024-05-15 Thread via GitHub
chia7712 commented on code in PR #15882: URL: https://github.com/apache/kafka/pull/15882#discussion_r1602161837 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1750,6 +1761,7 @@ Map allTasks() { if (stateUpdater != null) {

Re: [PR] KAFKA-10199: Handle assignment with new remove operation in state updater [kafka]

2024-05-16 Thread via GitHub
cadonna commented on code in PR #15882: URL: https://github.com/apache/kafka/pull/15882#discussion_r1603147808 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1750,6 +1761,7 @@ Map allTasks() { if (stateUpdater != null) {

Re: [PR] KAFKA-10199: Handle assignment with new remove operation in state updater [kafka]

2024-05-16 Thread via GitHub
cadonna commented on code in PR #15882: URL: https://github.com/apache/kafka/pull/15882#discussion_r1603565420 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1750,6 +1761,7 @@ Map allTasks() { if (stateUpdater != null) {