Re: [PR] KAFKA-10199: Revoke tasks from state updater with new remove [kafka]

2024-05-08 Thread via GitHub
cadonna merged PR #15871: URL: https://github.com/apache/kafka/pull/15871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-10199: Revoke tasks from state updater with new remove [kafka]

2024-05-08 Thread via GitHub
rishiraj88 commented on code in PR #15871: URL: https://github.com/apache/kafka/pull/15871#discussion_r1593553420 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -623,6 +623,21 @@ private void addToTasksToClose(final Map> futures,

Re: [PR] KAFKA-10199: Revoke tasks from state updater with new remove [kafka]

2024-05-07 Thread via GitHub
cadonna commented on code in PR #15871: URL: https://github.com/apache/kafka/pull/15871#discussion_r1592297149 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -623,6 +623,21 @@ private void addToTasksToClose(final Map> futures,

Re: [PR] KAFKA-10199: Revoke tasks from state updater with new remove [kafka]

2024-05-07 Thread via GitHub
lucasbru commented on code in PR #15871: URL: https://github.com/apache/kafka/pull/15871#discussion_r1592261128 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -623,6 +623,21 @@ private void addToTasksToClose(final Map> futures,

[PR] KAFKA-10199: Revoke tasks from state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna opened a new pull request, #15871: URL: https://github.com/apache/kafka/pull/15871 Uses the new remove operation of the state updater that returns a future to remove revoked tasks from the state udpater. ### Committer Checklist (excluded from commit message) - [ ] Verify