cadonna merged PR #13932:
URL: https://github.com/apache/kafka/pull/13932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
clolov commented on PR #13932:
URL: https://github.com/apache/kafka/pull/13932#issuecomment-1836217374
Heya @cadonna! Many thanks for the review and apologies for the delay. Yes,
it makes perfect sense, I also came across
```
I=0; while ./gradlew clients:test --tests RequestResponseTes
clolov commented on code in PR #13932:
URL: https://github.com/apache/kafka/pull/13932#discussion_r1412177600
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java:
##
@@ -3494,32 +3323,27 @@ private StreamThread setUpThread(final Properties
cadonna commented on code in PR #13932:
URL: https://github.com/apache/kafka/pull/13932#discussion_r1409103748
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java:
##
@@ -3494,32 +3323,27 @@ private StreamThread setUpThread(final Propertie
clolov commented on PR #13932:
URL: https://github.com/apache/kafka/pull/13932#issuecomment-1827568324
Polite ping @cadonna! I have found that
`shouldEnforceRebalanceWhenScheduledAndNotCurrentlyRebalancing[0] –
org.apache.kafka.streams.processor.internals.StreamThreadTest` is a bit flaky.
clolov commented on PR #13932:
URL: https://github.com/apache/kafka/pull/13932#issuecomment-1820768795
Heya @cadonna! Thanks for the review, I hope I have addressed all of your
comments. The pull request has also since been rebased.
--
This is an automated message from the Apache Git Serv
clolov commented on code in PR #13932:
URL: https://github.com/apache/kafka/pull/13932#discussion_r1397383304
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java:
##
@@ -203,6 +199,11 @@ public static Collection data() {
@SuppressWarn
cadonna commented on code in PR #13932:
URL: https://github.com/apache/kafka/pull/13932#discussion_r1396975782
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java:
##
@@ -125,11 +122,11 @@ public class ProcessorStateManagerTest {
ijuma commented on PR #13932:
URL: https://github.com/apache/kafka/pull/13932#issuecomment-1815017223
@cadonna Any chance you can help review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
clolov commented on PR #13932:
URL: https://github.com/apache/kafka/pull/13932#issuecomment-1814964376
Heya @ijuma! Divij is taking some time off, would it be possible for you to
review these pull requests as there are only a few left to finish the Mockito
migration for 3.7!
--
This is a
clolov commented on PR #13932:
URL: https://github.com/apache/kafka/pull/13932#issuecomment-1805861321
This has since been rebased!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
clolov commented on PR #13932:
URL: https://github.com/apache/kafka/pull/13932#issuecomment-1784954065
The pull request is still relevant! Don't review it for now, I will rebase
once more and address any outstanding comments and ping you when ready.
--
This is an automated message from th
divijvaidya commented on PR #13932:
URL: https://github.com/apache/kafka/pull/13932#issuecomment-1783154394
@clolov It's been a while since this PR. Is it still relevant? If yes, I can
take a look at this next week. Please rebase from trunk.
--
This is an automated message from the Apache
13 matches
Mail list logo
