Re: [PR] KAFKA-14438: Throw error when consumer configured with empty/whitespace-only group.id for AsyncKafkaConsumer [kafka]

2023-12-01 Thread via GitHub
kirktrue closed pull request #14768: KAFKA-14438: Throw error when consumer configured with empty/whitespace-only group.id for AsyncKafkaConsumer URL: https://github.com/apache/kafka/pull/14768 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-14438: Throw error when consumer configured with empty/whitespace-only group.id for AsyncKafkaConsumer [kafka]

2023-11-29 Thread via GitHub
cadonna commented on PR #14768: URL: https://github.com/apache/kafka/pull/14768#issuecomment-1832672849 @kirktrue My PR regarding [KAFKA-15281](https://issues.apache.org/jira/browse/KAFKA-15281) overlaps a lot with this. So I broke out the relevant parts for the group ID verification from

Re: [PR] KAFKA-14438: Throw error when consumer configured with empty/whitespace-only group.id for AsyncKafkaConsumer [kafka]

2023-11-29 Thread via GitHub
kirktrue commented on PR #14768: URL: https://github.com/apache/kafka/pull/14768#issuecomment-1832435606 @cadonna, can you take a look at this change? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-14438: Throw error when consumer configured with empty/whitespace-only group.id for AsyncKafkaConsumer [kafka]

2023-11-27 Thread via GitHub
kirktrue commented on PR #14768: URL: https://github.com/apache/kafka/pull/14768#issuecomment-1828804792 @mjsax would you be willing to review this PR? It's small and (hopefully!) straightforward. Thanks! -- This is an automated message from the Apache Git Service. To respond to the