Re: [PR] KAFKA-14504: Implement DescribeGroups API [kafka]

2023-10-06 Thread via GitHub
dajac merged PR #14462: URL: https://github.com/apache/kafka/pull/14462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-14504: Implement DescribeGroups API [kafka]

2023-10-05 Thread via GitHub
dajac commented on code in PR #14462: URL: https://github.com/apache/kafka/pull/14462#discussion_r1347070423 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -1210,6 +1229,11 @@ private void replay( lastWritt

Re: [PR] KAFKA-14504: Implement DescribeGroups API [kafka]

2023-10-04 Thread via GitHub
dongnuo123 commented on code in PR #14462: URL: https://github.com/apache/kafka/pull/14462#discussion_r1346196993 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -8686,6 +8695,88 @@ public void testListGroups() {

Re: [PR] KAFKA-14504: Implement DescribeGroups API [kafka]

2023-10-04 Thread via GitHub
dongnuo123 commented on code in PR #14462: URL: https://github.com/apache/kafka/pull/14462#discussion_r1346196163 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -521,6 +575,31 @@ GenericGroup getOrMaybeCreateGenericGroup(

Re: [PR] KAFKA-14504: Implement DescribeGroups API [kafka]

2023-10-04 Thread via GitHub
dajac commented on code in PR #14462: URL: https://github.com/apache/kafka/pull/14462#discussion_r1345506634 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -8686,6 +8695,88 @@ public void testListGroups() { ass

Re: [PR] KAFKA-14504: Implement DescribeGroups API [kafka]

2023-10-02 Thread via GitHub
dongnuo123 commented on code in PR #14462: URL: https://github.com/apache/kafka/pull/14462#discussion_r1343272684 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -444,6 +445,66 @@ public List listGroups(List statesFi

Re: [PR] KAFKA-14504: Implement DescribeGroups API [kafka]

2023-10-02 Thread via GitHub
dajac commented on code in PR #14462: URL: https://github.com/apache/kafka/pull/14462#discussion_r1342814124 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -444,6 +445,66 @@ public List listGroups(List statesFi re