Re: [PR] KAFKA-14505; [1/N] Add support for transactional writes to CoordinatorRuntime [kafka]

2023-11-29 Thread via GitHub
jolshan merged PR #14844: URL: https://github.com/apache/kafka/pull/14844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14505; [1/N] Add support for transactional writes to CoordinatorRuntime [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14844: URL: https://github.com/apache/kafka/pull/14844#discussion_r1408915256 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java: ## @@ -590,12 +590,18 @@ private ApiMessage

Re: [PR] KAFKA-14505; [1/N] Add support for transactional writes to CoordinatorRuntime [kafka]

2023-11-28 Thread via GitHub
jolshan commented on PR #14844: URL: https://github.com/apache/kafka/pull/14844#issuecomment-1831020682 Took a first pass and seems reasonable. The build had issues so I restarted it. I will look back again tomorrow. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-14505; [1/N] Add support for transactional writes to CoordinatorRuntime [kafka]

2023-11-28 Thread via GitHub
jolshan commented on code in PR #14844: URL: https://github.com/apache/kafka/pull/14844#discussion_r1408586225 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java: ## @@ -590,12 +590,18 @@ private ApiMessage

[PR] KAFKA-14505; [1/N] Add support for transactional writes to CoordinatorRuntime [kafka]

2023-11-27 Thread via GitHub
dajac opened a new pull request, #14844: URL: https://github.com/apache/kafka/pull/14844 This patch adds support for transactional writes to the `CoordinatorRuntime` framework. This mainly consists in adding `CoordinatorRuntime#scheduleTransactionalWriteOperation` and in adding the